Refactor develop command to act identical to PEP 660 editable wheels
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
messense
force-pushed
the
develop-is-editable
branch
from
75d5802
to
4a38a2b
Compare
messense
force-pushed
the
develop-is-editable
branch
from
4a38a2b
to
93f81f7
Compare
konstin
reviewed
Oct 15, 2021
| )?; | ||
| let wheels = build_context.build_wheels()?; | ||
| for (filename, _supported_version) in wheels.iter() { | ||
| let command = [ |
There was a problem hiding this comment.
Have you measured how long that takes? In the old implementation I intentionally didn't use pip at all because of the overhead of writing the archive, starting pip, reading the archive and writing the files out again, which you have to do after every rust change
There was a problem hiding this comment.
With the pyo3-mixed example it takes about 1 to 2 seconds to install the built wheel with pip which I think it's acceptable given that we don't have to reimplement entry points now.
messense
added a commit
to messense/maturin
that referenced
this pull request
Nov 15, 2022
After PyO3#653, `develop` tests already covered `editable` since it uses editable installs internally
bors bot
added a commit
that referenced
this pull request
Nov 15, 2022
1271: Remove unnecessary `editable` tests r=messense a=messense After #653, `develop` tests already covered `editable` since it uses editable installs internally Co-authored-by: messense <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #652